why does this exist? #478
Closed
why does this exist? #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
or what purpose it poses |
|
And because I don't know what this code does I've elected to remove it entirely and hope for the best ^^ |
|
?
…On Mon, Dec 23, 2024, 3:22 PM Agent X ***@***.***> wrote:
And because I don't know what this code does I've elected to remove it
entirely and hope for the best ^^
—
Reply to this email directly, view it on GitHub
<#478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2BZ7Z5DXDSKSN2232J3YKD2HB5K7AVCNFSM6AAAAABSSEIM4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGMYTCMRXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Why would I remove code I don't know what it does?
…On Mon, Dec 23, 2024, 3:45 PM Averey Conley ***@***.***> wrote:
?
On Mon, Dec 23, 2024, 3:22 PM Agent X ***@***.***> wrote:
> And because I don't know what this code does I've elected to remove it
> entirely and hope for the best ^^
>
> —
> Reply to this email directly, view it on GitHub
> <#478 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A2BZ7Z5DXDSKSN2232J3YKD2HB5K7AVCNFSM6AAAAABSSEIM4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGMYTCMRXGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
This exists because tiles in N64 have a size limit of 1024. If the UV is greater than 1024 it needs to be shifted so that it does not undergo coordinate overflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"fixes" uv map shift, was exporting a render96 mario for my friend but then the uv broke, looked in the code and found this, don't know if it's supposed to be there.